[dspam-users] blank lines after body,html tags

From: Alexei Korobkin <korobkin@src.samsung.ru>
Date: Thu Sep 29 2005 - 08:38:33 EDT

Dear All,

I already reported this issue to dev-list, but nobody answered.

There is a simple message enclosed with this letter (broken_message.eml). It
consists of two parts: base64 encoded html-body, and base64 encoded
attachment.
During message delivery Dspam inserts its signature to the end of html body.
Then Dspam closes tags <body> and <html>, and inserts attachement.

Here goes the bug: there is no trailing blank lines after </body></html>. We
can see tags and boundary glued together, like this
</BODY></HTML>--Boundary_(ID_ra6WtpC/AFYcZdtCamMoqg).

I suggest a patch, but first please somebody test attached message with your
dspam.

====================================
+++ dspam-3.6.rc3_patched/src/dspam.c Thu Sep 29 02:07:46 2005
*** dspam-3.6.rc3/src/dspam.c Thu Sep 29 08:30:32 2005
*** 3323,3329 ****
        if (dup)
        {
          buffer_cat (block->body, dup);
+ buffer_cat (block->body, "\r\n\r\n");
          free (dup);
        }
      }
====================================
Thank you for your attention.

--
With best regards, Alexei Korobkin. 

attached mail follows:


Received on Thu Sep 29 08:40:21 2005

This archive was generated by hypermail 2.1.8 : Thu Sep 29 2005 - 13:51:29 EDT