Re: [dspam-users] Problem with history (web interface)

Ok, thanks for the clue. I am new to creating patches or working on someone
else's code at all, really.
Attached is a unified diff output.

In the future, if I add a feature or fix a bug in the webui, what is the
best/most appropriate way to share that with
others? Or am I not supposed to do that at all?
I plan to add some things that my users have been requesting (checkboxes on
history screen for
retraining multiple items, paging on the quarantine screen, etc). But I
don't want to step on any toes or cause any
problems by sharing those patches in the wrong way.

-Aaron

On 1/22/06, John Peacock <jpeacock@rowman.com> wrote:
>
> Aaron Wolfe wrote:
> > Ok, below is the "patch" for dspam.cgi.. its more a rewrite of the
> > DisplayHistory sub.
> > It works for me, I hope it works for anyone else that is bothered by the
> > issues with the current webui history page.
> > If you find errors or know a better way to do this, please let me know.
> >
> > -Aaron
>
> Two things:
>
> 1) Please use 'diff -u' or 'diff -c' when submitting diffs (unified or
> context
> diffs, respectively, are much easier for humans to review).
>
> 2) It would be better to send the diff as an attachment (to prevent your
> mail
> client from munging long lines), but if you are going to include it in the
> body
> of a message, please do not also include remnants of the message thread
> (since
> the same line marker is used for "newfile" as for "previous message").
>
> John
>
> --
> John Peacock
> Director of Information Research and Technology
> Rowman & Littlefield Publishing Group
> 4720 Boston Way
> Lanham, MD 20706
> 301-459-3366 x.5010
> fax 301-429-5747
>